Unset default value of keyProperty. #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It causes a problem like mybatis#902 and makes it difficult to handle errors in Jdbc3KeyGenerator.
|
+1 |
kazuki43zoo
added
the
no backward compatibility
kazuki43zoo
added a commit
that referenced
this pull request
Apr 12, 2018
h3adache
pushed a commit
that referenced
this pull request
May 5, 2018
pulllock
pushed a commit
to pulllock/mybatis-3
that referenced
this pull request
Oct 19, 2023
Unset default value of keyProperty.
pulllock
pushed a commit
to pulllock/mybatis-3
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation sets "id" as the default value of
keyProperty.But having default value makes it difficult to report helpful errors from Jdbc3KeyGenerator (see #782 and #902).
As it is possible that there are solutions relying on this default value, the target is set to 3.5.0.